build: remove fix commit message label as it breaks with autosquash strategy #2696
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angular-robot
bot
added
the
area: build & ci
devversion
added
the
action: review
josephperrott
requested changes
Mar 31, 2025
Member
josephperrott
left a comment
josephperrott
left a comment
There was a problem hiding this comment.
We need to modify the usages in ng-dev/pr/common/validation/assert-allowed-target-label.ts and ng-dev/pr/merge/pull-request.ts
Member
Author
|
Wow, good catch— though it does look like the build passes?! |
…trategy This label and its merge script mode don't work properly with auto-squash. The label was initially built in the components repository; which doesn't use autosquashing. We should not re-add the label automatically.
devversion
force-pushed
the
disable-label
branch
from
c1e1757 to
c8c270d
Compare
Member
Author
|
Changed it to just not sync into FW. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This label and its merge script mode don't work properly with auto-squash. The label was initially built in the components repository; which doesn't use autosquashing.
We should not re-add the label automatically.