feat(bazel): support Karma spec bundling with rules_js
#2697
+78
−316
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josephperrott
approved these changes
Mar 31, 2025
We need AMD spec bundling for Karma, until we have our own IIFE-capable ruleset. This is a small layer on top of our much simpler spec bundling rule. Note that we switch to `rules_esbuild` as otherwise Esbuild can escape sandbox due to its Go-based resolution.
devversion
force-pushed
the
spec-bundling-amd
branch
from
a78bb57 to
c7b48a4
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need AMD spec bundling for Karma, until we have our own IIFE-capable ruleset. This is a small layer on top of our much simpler spec bundling rule.
Note that we switch to
rules_esbuildas otherwise Esbuild can escape sandbox due to its Go-based resolution.