Skip to content

refactor(ng-dev): properly check if wombot proxy is logged in when checking npm login state #3284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alan-agius4 merged 1 commit into from
Dec 4, 2025
Merged

refactor(ng-dev): properly check if wombot proxy is logged in when checking npm login state #3284

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 0 additions & 11 deletions ng-dev/release/publish/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,17 +205,6 @@ export class ReleaseTool {
*/
private async _verifyNpmLoginState(): Promise<boolean> {
const registry = `NPM at the ${this._config.publishRegistry ?? 'default NPM'} registry`;
// TODO(josephperrott): remove wombat specific block once wombot allows `npm whoami` check to
// check the status of the local token in the .npmrc file.
if (this._config.publishRegistry?.includes('wombat-dressing-room.appspot.com')) {
Log.info('Unable to determine NPM login state for wombat proxy, requiring login now.');
try {
await NpmCommand.startInteractiveLogin(this._config.publishRegistry);
} catch {
return false;
}
return true;
}
if (await NpmCommand.checkIsLoggedIn(this._config.publishRegistry)) {
Log.debug(`Already logged into ${registry}.`);
return true;
Expand Down
Loading