Skip to content

fix(bazel): correct typescript version validation logic #3292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
josephperrott merged 1 commit into from
Dec 5, 2025
Merged

fix(bazel): correct typescript version validation logic #3292

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions bazel/validation/verify-typescript.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,16 +34,15 @@ async function main([packageJsonPath, moduleLockFilePath]) {
// the first value/item from the `generaredRepoSpecs` property and get the version from the
// attributes there.
const generatedRepoSpecs =
// TODO: Remove pre bazel v8 lockfile attribute path.
moduleLock['moduleExtensions']?.['@@aspect_rules_ts~//ts:extensions.bzl%ext']?.['general']?.[
'generatedRepoSpecs'
] ||
moduleLock['moduleExtensions']?.['@@aspect_rules_ts+//ts:extensions.bzl%ext']?.['general']?.[
'generatedRepoSpecs'
];
lockfileVersion =
// TODO: Remove pre bazel v8 lockfile attribute path.
Object.values(generatedRepoSpecs || {})[0]?.['attributes']?.['version'] ||
moduleLock['moduleExtensions']['@@aspect_rules_ts+//ts:extensions.bzl%ext']['general'][
'generatedRepoSpecs'
]['npm_typescript']?.['attributes']?.['version'] ||
'unknown';
Object.values(generatedRepoSpecs || {})[0]?.['attributes']?.['version'] || 'unknown';
} catch {
console.error('Unable to find the typescript version within the MODULE.bazel.lock file.');
}
Expand Down
Loading