refactor: Update most frequently updating groups to run on Thursdays

[thePunderWoman]

At least two of the named groups in our renovate config are spammy sending out multiple PRs in a given day and can be overwhelming for the caretaker. Switching them to Thursdays means all the updates will happen then on the first day of the cycle, allowing the rest of the time as caretaker to be less noisy.

[alan-agius4]

In general it looks good, but I want to understand a bit more somethings you comment in your commit message

"renovate config are spammy sending out multiple PRs in a given day and can be overwhelming for the caretaker".

These groups are schedule to open PR on Monday, Wednesday and Friday between 6am - 10am CET time https://github.com/thePunderWoman/dev-infra/blob/c0dada5f91bcf41c4f0706a7b01edf51f300d4a2/renovate-presets/default.json5#L9, so this the issue might be something else? Do you have an example?

For the NPM group updates can we choose a date closer to the release? (Wednesday maybe)?

The reason being, is that If an NPM package is release on Monday, waiting an extra week for package availability since it will be available not in the current week release but the next one slows down our delivery cycle and limits early visibility into potential bugs during the next period.

Increase the prConcurrentLimit

Since we are reducing the frequency of these dependency updates from three times a week to once a week, we should increase our concurrent PR limit. If we don't, we risk a significant backlog where updates are delayed by an additional week. I recommend increasing prConcurrentLimit from 8 to 10 (or higher) to ensure Renovate can clear the queue within its new, limited window.

[thePunderWoman]

@alan-agius4 Responding to your comments:

1. Right now half the PRs in the merge queue are robot PRs. The FW team has regularly discussed, including this week, how there's just too many of these that it ends up being the majority of a caretaker's merging work to keep up with these. Having them all on one day is much more ideal.

2. We deliberately wanted them to be after the release for the next caretaker. Having them on Thursday means post release, we have a full week to clear out all the robot PRs. The exception being cross repo deps and adev docs. If there's a critical bug in a dep, we can always visit the dependency dashboard and force the update for that one.

3. Yeah, it makes sense to update the concurrency.

[alan-agius4]

1. Right now half the PRs in the merge queue are robot PRs. The FW team has regularly discussed, including this week, how there's just too many of these that it ends up being the majority of a caretaker's merging work to keep up with these. Having them all on one day is much more ideal.

You may want to add a schedule here too: https://github.com/thePunderWoman/dev-infra/blob/d24cff1ae722b0a42cf6e321fb06cd38071e1df2/renovate-presets/default.json5#L99 and delete https://github.com/angular/dev-infra/blob/dd5658bd720370542913e23b21d80450bac94b60/renovate-presets/default.json5#L150:L159 as otherwise we end up in a state where we have conflicting schedules.

2. We deliberately wanted them to be after the release for the next caretaker. Having them on Thursday means post release, we have a full week to clear out all the robot PRs. The exception being cross repo deps and adev docs. If there's a critical bug in a dep, we can always visit the dependency dashboard and force the update for that one.

SGTM

[alan-agius4]

LGTM, just a couple of NITs.

[josephperrott]

LGTM

[alan-agius4]

@jessicajaniuk looks like the below is still pending.

and delete https://github.com/angular/dev-infra/blob/dd5658bd720370542913e23b21d80450bac94b60/renovate-presets/default.json5#L150:L159 as otherwise we end up in a state where we have conflicting schedules.

[thePunderWoman]

@alan-agius4 I didn't delete it, but updated it to have the same schedule on Thursdays. Do you prefer I still delete?

[alan-agius4]

@alan-agius4 I didn't delete it, but updated it to have the same schedule on Thursdays. Do you prefer I still delete?

Yes, since now, it’s captured with the other group.

[alan-agius4]

This following is missing than

You may want to add a schedule here too: https://github.com/thePunderWoman/dev-infra/blob/d24cff1ae722b0a42cf6e321fb06cd38071e1df2/renovate-presets/default.json5#L99

[thePunderWoman]

@alan-agius4 ok, deleted that section and added the schedule to the github actions one.

[alan-agius4]

This PR was merged into the repository. The changes were merged into the following branches:

• main: c23dd2d