build: update ghcr.io/puppeteer/puppeteer docker tag to v25#3664
Conversation
See associated pull request for more information.
There was a problem hiding this comment.
Code Review
This pull request updates the Puppeteer base image in the Dockerfile from version 24.43.0 to 25.0.0. A review comment identifies a potential issue where this upgrade likely transitions the base OS from Debian Bullseye to Bookworm, which may cause conflicts with existing manual repository configurations later in the file.
| @@ -1,5 +1,5 @@ | |||
| # https://github.com/puppeteer/puppeteer/blob/866addd132270e56cb1f84885f2897123087215c/docker/Dockerfile | |||
| FROM ghcr.io/puppeteer/puppeteer:24.43.0@sha256:5c098117ef34084ba6f9dcff0fb2d8c9ee8f206297d3e227c695b7c73c52ebca | |||
| FROM ghcr.io/puppeteer/puppeteer:25.0.0@sha256:ecdb48b707c73cc8113ede6610faf2d84d5af9c276244f82b13386cd853c02c4 | |||
There was a problem hiding this comment.
The upgrade to Puppeteer v25 (which requires Node 22) likely transitions the base image from Debian Bullseye to Debian Bookworm. This change makes the manual addition of the bullseye repository on line 10 incorrect and potentially harmful due to mixing Debian releases. The repository should be updated to bookworm or removed if firefox-esr is available in the default repositories of the new base image.
|
This PR was merged into the repository. The changes were merged into the following branches:
|
This PR contains the following updates:
24.43.0→25.0.1Release Notes
puppeteer/puppeteer (ghcr.io/puppeteer/puppeteer)
v25.0.1♻️ Chores
Dependencies
🛠️ Fixes
v25.0.0⚠ BREAKING CHANGES
🎉 Features
📄 Documentation
🏗️ Refactor
Dependencies
🛠️ Fixes
⚡ Performance
v24.43.1♻️ Chores
Dependencies
🛠️ Fixes
⚡ Performance