This repository was archived by the owner on Apr 4, 2025. It is now read-only.
fix(@schematics/angular): fix missing link attribute for PWA#141
Merged
Brocco merged 1 commit intoangular:masterfrom Sep 19, 2017
markgoho:patch-1
Merged
fix(@schematics/angular): fix missing link attribute for PWA#141Brocco merged 1 commit intoangular:masterfrom markgoho:patch-1
Brocco merged 1 commit intoangular:masterfrom
markgoho:patch-1
Conversation
This change fixes a security/performance issue in links that open in new windows, and by the same token, increases the lighthouse score for PWAs. Assuming we (eventually) want a CLI-generated Angular project to be 100% PWA, this is a necessary change.
filipesilva
approved these changes
Sep 7, 2017
Contributor
filipesilva
left a comment
filipesilva
left a comment
There was a problem hiding this comment.
LGTM, thanks for fixing this 👍
Brocco
approved these changes
Sep 11, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change fixes a security/performance issue in links that open in new windows, and by the same token, increases the lighthouse score for PWAs. Assuming we (eventually) want a CLI-generated Angular project to be 100% PWA, this is a necessary change.