This repository was archived by the owner on Apr 4, 2025. It is now read-only.
feat(@schematics/angular): Add universal schematic #254
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filipesilva
suggested changes
Nov 3, 2017
| ], | ||
| bootstrap: [AppComponent], | ||
| }) | ||
| export class AppServerModule {} |
Contributor
There was a problem hiding this comment.
This should be __rootModuleFileName__ instead of AppServerModule.
| test: options.test, | ||
| tsconfig: options.tsconfigFileName, | ||
| testTsconfig: options.testTsconfigFileName, | ||
| environmentSource: 'environments/environment.ts', |
Contributor
There was a problem hiding this comment.
environments should be used together with environments, or not at all.
Brocco
force-pushed
the
universal-schematic
branch
from
d47daa4 to
c6f8c29
Compare
Contributor
Author
|
I've addressed the comments from @filipesilva |
|
Would it be possible to augment the main.ts to include This is essential for StateTransfer which is a likely addition to Universal and often overlooked/unknown |
Contributor
|
Opened angular/angular#20484 to investigate how to avoid the race condition in TransferState without needing specific way to bootstrap the client side. We should make TransferState work more transparently to the user. |
Brocco
force-pushed
the
universal-schematic
branch
4 times, most recently
from
70d9753 to
0eec4c0
Compare
filipesilva
previously approved these changes
Nov 20, 2017
hansl
reviewed
Nov 20, 2017
| const recorder = host.beginUpdate(mainPath); | ||
| const beforeText = `document.addEventListener('DOMContentLoaded', () => {\n `; | ||
| const afterText = `\n});`; | ||
| recorder.insertRight(bootstrapCall.getStart(), beforeText); |
Brocco
force-pushed
the
universal-schematic
branch
from
0eec4c0 to
47d0512
Compare
hansl
approved these changes
Nov 21, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.