This repository was archived by the owner on Apr 4, 2025. It is now read-only.
refactor(@schematics/update): use npm-registry-client to get data#692
Merged
clydin merged 1 commit intoangular:masterfrom Apr 19, 2018
clydin:npm-registry
Merged
refactor(@schematics/update): use npm-registry-client to get data#692clydin merged 1 commit intoangular:masterfrom clydin:npm-registry
clydin merged 1 commit intoangular:masterfrom
clydin:npm-registry
Conversation
hansl
suggested changes
Apr 12, 2018
| }); | ||
| client.log.level = 'silent'; | ||
| const params = { | ||
| timeout: 1000, |
Contributor
There was a problem hiding this comment.
I'd say 30 seconds is fine. All requests are executed in parallel aynway.
| } | ||
| }); | ||
| response.on('error', err => subject.error(err)); | ||
| const client = new RegistryClient({ |
Contributor
There was a problem hiding this comment.
Are there any proxy information to be passed in?
Member
Author
There was a problem hiding this comment.
not added yet. wanted to make sure it was an adequate replacement first.
hansl
approved these changes
Apr 19, 2018
This was referenced May 22, 2018
15 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current
npmsettings forregistry,proxy, andhttps-proxywill also be automatically used if present.