This repository was archived by the owner on Jan 19, 2024. It is now read-only.
Size task #21
Merged
Size task #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ocombe
approved these changes
Sep 19, 2018
functions/src/plugins/size.ts
Outdated
| } else if (statusEvent.state === STATUS_STATE.Failure) { | ||
| await this.setStatus( | ||
| STATUS_STATE.Error, | ||
| `Unable to calculate sizes. Failure: "${config.circleCiStatusName}"`, |
Contributor
There was a problem hiding this comment.
There an extra space before "Failure"
functions/src/plugins/size.ts
Outdated
| async upsertNewArtifacts( | ||
| context: Context, | ||
| artifacts: BuildArtifact[] | ||
| ): Promise<void> { |
Contributor
There was a problem hiding this comment.
Can you put the function definition on one line instead of 4 ?
Contributor
|
Seems good, just some minor cosmetic remarks |
ocombe
approved these changes
Sep 20, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.