-
Notifications
You must be signed in to change notification settings - Fork 9
feat: Add CircleCI workflow rerun when a specific label is added to a PR #41
Conversation
| return; | ||
| } | ||
| const {owner, repo} = context.repo(); | ||
| const circleCiUrl = `https://circleci.com/api/v1.1/project/github/${owner}/${repo}/build?circle-token=${circleToken}`; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still need to determine how to store and retrieve this token at runtime.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
|
Igor and I were talking about this method of being able to trigger reruns of CircleCI ad hoc. |
5f7797b to
fe8c1b9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good overall, just a few comments and we need to add the dev config check
IgorMinar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ocombe's comments +1
but do rework the naming and labels - it must be clear what this check does. And we don't need to mention "CircleCI" in the label, because once we add buildkite for real, we should rerun buildkite builds with the very same label.
| // set to true to disable | ||
| disabled: true, | ||
| // the label which when added triggers a rerun of the default CircleCI workflow. | ||
| triggerRerunLabel: 'Trigger CircleCI Rerun'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this default label is too long and misleading. We are not just rerunning the CircleCI workflow, we are rerunning it rebased against the latest HEAD of the target branch.
Maybe "Rerun CI against HEAD"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My concern with just saying CI is that not all things that show up on CI will be rerun, g3 presubmits being an example.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll merge this for now, since this label will be part of the config on each repo anyway you can debate the name of the label on the PR that @josephperrott will make to update the config file
fe8c1b9 to
b23f182
Compare
No description provided.