Skip to content
This repository was archived by the owner on Jan 19, 2024. It is now read-only.

Conversation

@josephperrott
Copy link
Member

No description provided.

return;
}
const {owner, repo} = context.repo();
const circleCiUrl = `https://circleci.com/api/v1.1/project/github/${owner}/${repo}/build?circle-token=${circleToken}`;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still need to determine how to store and retrieve this token at runtime.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@josephperrott
Copy link
Member Author

@IgorMinar @ocombe

Igor and I were talking about this method of being able to trigger reruns of CircleCI ad hoc.

@josephperrott josephperrott force-pushed the rerun-circle branch 2 times, most recently from 5f7797b to fe8c1b9 Compare February 12, 2019 23:43
Copy link
Contributor

@ocombe ocombe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good overall, just a few comments and we need to add the dev config check

Copy link
Contributor

@IgorMinar IgorMinar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ocombe's comments +1

but do rework the naming and labels - it must be clear what this check does. And we don't need to mention "CircleCI" in the label, because once we add buildkite for real, we should rerun buildkite builds with the very same label.

// set to true to disable
disabled: true,
// the label which when added triggers a rerun of the default CircleCI workflow.
triggerRerunLabel: 'Trigger CircleCI Rerun';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this default label is too long and misleading. We are not just rerunning the CircleCI workflow, we are rerunning it rebased against the latest HEAD of the target branch.

Maybe "Rerun CI against HEAD"?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My concern with just saying CI is that not all things that show up on CI will be rerun, g3 presubmits being an example.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll merge this for now, since this label will be part of the config on each repo anyway you can debate the name of the label on the PR that @josephperrott will make to update the config file

@ocombe ocombe merged commit e412948 into angular:master Feb 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants