This repository was archived by the owner on Jan 19, 2024. It is now read-only.
fix: don't update g3status on merge label #43
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IgorMinar
approved these changes
Feb 28, 2019
Contributor
IgorMinar
left a comment
IgorMinar
left a comment
There was a problem hiding this comment.
can you please update the comment message with info about this change? and can you please do that for future PRs as well?
It's very difficult to review PRs without description and especially if they don't add new specs.
otherwise lgtm... I guess (since there are not tests it's hard to be confident)...
We were updating the g3status when the merge label was added. This meant that if a g3sync had updated the status, it was overwritten. With this PR we now only update the g3status on sync (new commit or force push) or when the g3status is missing.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.