This repository was archived by the owner on Jan 19, 2024. It is now read-only.
fix: g3Status check only checks against the branch being synced in g3 #51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously all changes where checked for if the file was synced to g3. However only a single branches files are actually synced, typically master. This change now confirms that changes are targetting a branch we care about, if it does not the status is marked as passing.
IgorMinar
approved these changes
Apr 6, 2020
Contributor
IgorMinar
left a comment
IgorMinar
left a comment
There was a problem hiding this comment.
lgtm if you add a test :)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously all changes where checked for if the file was synced to g3.
However only a single branches files are actually synced, typically
master. This change now confirms that changes are targetting a branch
we care about, if it does not the status is marked as passing.