Skip to content
This repository was archived by the owner on Jan 19, 2024. It is now read-only.

refactor: allow use-case and confusing types to be marked as 'triaged' #64

Closed
atscott wants to merge 1 commit into from
Closed

refactor: allow use-case and confusing types to be marked as 'triaged' #64

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion functions/src/default.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,14 @@ If you can't get the PR to a green state due to flakes or broken master, please
// arrays of labels that determine if an issue has been triaged by the caretaker
l1TriageLabels: [["comp: *"]],
// arrays of labels that determine if an issue has been fully triaged
l2TriageLabels: [["type: bug/fix", "severity*", "freq*", "comp: *"], ["type: feature", "comp: *"], ["type: refactor", "comp: *"], ["type: RFC / Discussion / question", "comp: *"]]
l2TriageLabels: [
Copy link
Member

@josephperrott josephperrott Jul 15, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since these are just the default values, why don't we just modify them in the angular/angular repository config file?

The angular/angular config file already actually sets its own it appears (link)

Copy link
Contributor Author

@atscott atscott Jul 15, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah! Yes, that's definitely better; I wasn't aware of that. I'll make the change there

["type: bug/fix", "severity*", "freq*", "comp: *"],
["type: use-case", "freq*", "comp: *"],
["type: confusing", "freq*", "comp: *"],
["type: feature", "comp: *"],
["type: refactor", "comp: *"],
["type: RFC / Discussion / question", "comp: *"]
]
},

// triage for PRs
Expand Down
6 changes: 6 additions & 0 deletions test/triage.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,12 @@ describe('triage', () => {

isTriaged = triageTask.isTriaged(config.l2TriageLabels, ['comp: common/http', 'type: bug/fix', 'freq1: low', 'severity3: broken']);
expect(isTriaged).toBeTruthy();

isTriaged = triageTask.isTriaged(config.l2TriageLabels, ['comp: router', 'type: use-case', 'freq1: low'])
expect(isTriaged).toBeTruthy();

isTriaged = triageTask.isTriaged(config.l2TriageLabels, ['comp: router', 'type: confusing', 'freq1: low'])
expect(isTriaged).toBeTruthy();
});
});
});