Skip to content
This repository was archived by the owner on Dec 18, 2024. It is now read-only.

fix: remove workarounds for async pipe type narrowing bug #926

Merged
merged 1 commit into from
Mar 1, 2021
Merged

fix: remove workarounds for async pipe type narrowing bug #926

merged 1 commit into from
Mar 1, 2021

Conversation

@Splaktar
Copy link
Contributor

@Splaktar Splaktar commented Mar 1, 2021

@Splaktar Splaktar self-assigned this Mar 1, 2021
@google-cla google-cla bot added the cla: yes label Mar 1, 2021
@Splaktar Splaktar mentioned this pull request Mar 1, 2021
Merged
crisbeto
crisbeto approved these changes Mar 1, 2021
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Splaktar Splaktar merged commit d238b5d into angular:master Mar 1, 2021
@Splaktar Splaktar deleted the remove-async-pipe-bug-workarounds branch March 1, 2021 20:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@andrewseguin andrewseguin Awaiting requested review from andrewseguin

1 more reviewer

@crisbeto crisbeto crisbeto approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Splaktar Splaktar

Labels

cla: yes P3: important pr: lgtm pr: merge ready

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ngIf with async pipe causes new template type checking errors when template variables are used in rc.5

2 participants

@Splaktar @crisbeto