This repository was archived by the owner on Dec 18, 2024. It is now read-only.
fix(sidenav): unable to scroll sidenav as expected #978
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a bug in sidenav where user has to scroll to bottom of the page to reach bottom of navigation Fixes angular#857
Splaktar
suggested changes
May 7, 2021
Contributor
Splaktar
left a comment
Splaktar
left a comment
There was a problem hiding this comment.
Thank you for looking into this! However, it doesn't quite get us what we need as you can see in the screenshot. There is a big space between the bottom of the menu and the bottom of the page.
I'll look into this a little more and try to suggest some changes that will not have this issue.
Splaktar
reviewed
May 7, 2021
Contributor
Splaktar
left a comment
Splaktar
left a comment
There was a problem hiding this comment.
This seems to improve things while avoiding the gap.
…ole page to bottom
Splaktar
approved these changes
May 7, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug in sidenav where user has to scroll to bottom of the page to reach bottom of navigation
Fixes #857