Skip to content
This repository was archived by the owner on Sep 5, 2024. It is now read-only.

Conversation

@5earle
Copy link
Contributor

@5earle 5earle commented Feb 3, 2018

PR Checklist

Please check that your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: 9153

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot. The email used to register you as an authorized contributor must be the email used for the Git commit.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

@googlebot googlebot added the cla: no PR author needs to sign Google's CLA: https://opensource.google.com/docs/cla/ label Feb 3, 2018
@5earle
Copy link
Contributor Author

5earle commented Feb 3, 2018

I signed it

@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ and removed cla: no PR author needs to sign Google's CLA: https://opensource.google.com/docs/cla/ labels Feb 3, 2018
@5earle 5earle changed the title Fix JSHint Warnings Fix(JSHint)Warnings Feb 4, 2018
@5earle
Copy link
Contributor Author

5earle commented Feb 4, 2018

Addresses #9153

Remove JSHint warnings

@5earle 5earle closed this Feb 6, 2018
@5earle 5earle deleted the fix-jshint-warnings branch February 6, 2018 02:10
@5earle 5earle restored the fix-jshint-warnings branch February 6, 2018 02:23
@5earle 5earle deleted the fix-jshint-warnings branch February 6, 2018 02:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants