Skip to content

refactor: switch to HttpClient#6702

Merged
mmalerba merged 1 commit intoangular:masterfrom
crisbeto:http-client
Oct 24, 2017
Merged

refactor: switch to HttpClient#6702
mmalerba merged 1 commit intoangular:masterfrom
crisbeto:http-client

Conversation

@crisbeto
Copy link
Member

@crisbeto crisbeto commented Aug 29, 2017

Refactors all of the usages of the deprecated Http by replacing them with the HttpClient.

Note: We need to keep @angular/http as a dev dependency in order for the prerender CI check to work.

BREAKING CHANGE: Material now requires @angular/common instead of @angular/http and uses HttpClient instead of Http.

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Aug 29, 2017
@crisbeto crisbeto changed the title refactor: switch HttpClient refactor: switch to HttpClient Aug 29, 2017
@rafaelss95
Copy link
Contributor

I think it's already covered by #6454.

Copy link
Contributor

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn
Copy link
Contributor

@crisbeto just needs rebase

@jelbourn jelbourn added the merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note label Aug 30, 2017
@jelbourn
Copy link
Contributor

Caretaker note: if anyone is mocking the requests in google we'll need to update their tests

@jelbourn
Copy link
Contributor

Looks like this one needs rebease

@crisbeto
Copy link
Member Author

Rebased.

@crisbeto crisbeto added the P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful label Sep 14, 2017
@mmalerba
Copy link
Contributor

please rebase

@mmalerba mmalerba removed the action: merge The PR is ready for merge by the caretaker label Sep 15, 2017
@crisbeto crisbeto force-pushed the http-client branch 2 times, most recently from 6c1f4bb to ff9553d Compare September 21, 2017 20:35
@princemaple
Copy link
Contributor

Will this be merged soon? Was hoping it could make beta 11, well...

@cyrilletuzi
Copy link
Contributor

cyrilletuzi commented Sep 22, 2017

@rafaelss95 thanks for noticing my work ;)

@jelbourn
Copy link
Contributor

Status update: after some super fun time debugging an issue with HttpClient and Closure Compiler, we have a fix (angular/angular#19360, plus some internal google stuff), on top of having patches ready for Google apps' tests that depended on the old MockBackend done

@crisbeto crisbeto force-pushed the http-client branch 2 times, most recently from 2605e72 to add4419 Compare October 4, 2017 17:29
@andrewseguin
Copy link
Contributor

Needs rebase

@andrewseguin andrewseguin added pr: needs rebase and removed action: merge The PR is ready for merge by the caretaker labels Oct 12, 2017
@crisbeto
Copy link
Member Author

Rebased @andrewseguin.

@crisbeto crisbeto added action: merge The PR is ready for merge by the caretaker and removed pr: needs rebase labels Oct 12, 2017
@andrey-programmist
Copy link

andrey-programmist commented Oct 13, 2017

It's need to remove @angular/http from platform-server
http

Refactors all of the usages of the deprecated `Http` by replacing them with the `HttpClient`.

BREAKING CHANGE: Material now requires `@angular/common` instead of `@angular/http` and uses `HttpClient` instead of `Http`.
@Splaktar
Copy link
Contributor

Splaktar commented Dec 8, 2017

This merge did unfortunately add back MdIconRegistry instead of MatIconRegistry: https://github.com/angular/material2/blob/master/src/lib/icon/icon-registry.ts#L491

@andrewseguin
Copy link
Contributor

Thanks @Splaktar - made PR in #8940

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants