Wrong typings for `each()` method

[inad9300]

In Protractor 5.2.2 (and in previous versions too), the typings for the each() method of the ElementArrayFinder class are defined like so:

each(fn: (elementFinder?: ElementFinder, index?: number) => any): wdpromise.Promise<any>;

This is a misunderstanding of TypeScript ? modifier. What you are saying with such a type for fn is that fn may receive 0 arguments, 1 argument or 2 arguments depending on the case. What you want to represent isn't this – each() will every single time receive both elementFinder and index.

This kind of errors are now becoming evident thanks to TypeScript's new --strictFunctionTypes flag, causing a lot of compilation problems.

Many other functions (e.g. map()) contain the same mistake.

[wswebcreation]

@inad9300 , care for a PR ;-)?

[inad9300]

@wswebcreation Done ;)