This repository was archived by the owner on Jul 29, 2024. It is now read-only.
Selenium 3 upgrade #3743
Closed
Selenium 3 upgrade #3743
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cnishina
force-pushed
the
selenium3
branch
2 times, most recently
from
c94b4c3 to
6a63523
Compare
Contributor
Author
|
This is failing because of the node version on circle ci and probably will do the same on travis. |
cnishina
force-pushed
the
selenium3
branch
3 times, most recently
from
51eddd4 to
1adc0e1
Compare
Contributor
Author
|
Travis is now on node 6 and 7 and should pass. Circle CI is failing to pass the full test suite... |
cnishina
force-pushed
the
selenium3
branch
2 times, most recently
from
57f9f5c to
29f1aff
Compare
Contributor
Author
|
direct connect and element explorer failures. 😕 |
…bdriver for version 3
- update to selenium-webdriver 3.0.1 - fix expected conditions test - verify basic tests pass
using selenium standalon server 2.53.1
- upgrade to selenium-webdriver 3.0.x requires node version 6+, updating
travis and circle yml to use node 6
- firefox 47 works
- selenium-webdriver/testing uses the global.it and cannot be
reassigned as Protractor's global it. Required to copy some of their code
to the lib/frameworks/mocha.js file
- WIP: still have tests that are not passing.
using selenium standalone server 3.0.x
- firefox 49 with gecko driver 0.11.1 does not work
- firefox 48 with gecko driver 0.11.1 appears to work for
a single test but after it quits, selenium standalone
no longer works with firefox.
- when firefox 48 exists, logs show the following:
```
20:01:14.814 INFO - Executing: [delete session: e353fa1b-e266-4ec3-afb3-88f11a82473a])
[GFX1-]: Receive IPC close with reason=AbnormalShutdown
[Child 30665] ###!!! ABORT: Aborting on channel error.: file /builds/slave/m-rel-m64-00000000000000000000/build/src/ipc/glue/MessageChannel.cpp, line 2052
[Child 30665] ###!!! ABORT: Aborting on channel error.: file /builds/slave/m-rel-m64-00000000000000000000/build/src/ipc/glue/MessageChannel.cpp, line 2052
```
- webdriver.quit throws a no session error - define "quit" at runner.ts similar to restart where the driverprovider calls quit instead of the webdriver
- breakpoint updated to lib/http.js line 432
- removed method WebDriver.prototype.isElementPresent - removed method WebElement.prototype.getRawId
- Chrome requires a ServiceBuilder and to call the Service to createSession - Since this upgrade is still using FF 47, direct connect for Firefox is required to pass "marionette: false" in the capabilities. If you do not pass marionette to false, it will look for gecko driver in the PATH. - Added a TODO to support FF after 48 with direct connect and gecko driver.
- added TODO to enable tests again.
Contributor
Author
|
Closing this in favor of #3781 to use a beta branch. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Selenium 3 upgrade WIP...still does not work with FF.