This repository was archived by the owner on Jul 29, 2024. It is now read-only.
Add support for end users changing the httpAgent. #4926
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From version 3.0.0-beta-1, the Selenium-Webdriver package allows the httpAgent to be configured. This change adds httpAgent to the config file, as well as support in driverProvider. It also sets the httpAgent to sauceAgent, where sauceAgent is in use. (Making the assumption that anyone who needs a sauceAgent for the Sauce Labs REST API also needs it to connect to Sauce Labs for testing)
mipark2csco
reviewed
Aug 21, 2018
lib/driverProviders/sauce.ts
Outdated
| this.config_.capabilities['build'] = this.config_.sauceBuild; | ||
|
|
||
| if (this.config_.sauceAgent) { | ||
| this.config_.httpAgent = this.config_.httpAgent; |
There was a problem hiding this comment.
-
@DylanLacey - should this be:
- this.config_.httpAgent = this.config_.httpAgent; + this.config_.httpAgent = this.config_.sauceAgent;
...?
Contributor
Author
There was a problem hiding this comment.
It sure should. Updating that now.
There was a problem hiding this comment.
@DylanLacey - f15c7d8 seems to be missing this change?
|
Any update on when this change will be pulled in? My company is waiting on this item to use the ondemand.saucelabs.com through a corporate proxy. |
|
Following up on cbrown1982's question as we are also waiting on this to be accepted for a corporate proxy. Can this be accepted? |
|
Also following up, this feature is much needed. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From version 3.0.0-beta-1, the Selenium-Webdriver package allows
the httpAgent to be configured.
This change adds httpAgent to the config file, as well as support
in driverProvider.
It also sets the httpAgent to sauceAgent, where sauceAgent is in use.
(Making the assumption that anyone who needs a sauceAgent for the
Sauce Labs REST API also needs it to connect to Sauce Labs for testing)
NB: I wasn't sure what kind of tests are appropriate beyond testing that the agent is set, and that that sets the agent... Happy to add that if desired.