-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Browser.get break AngularJS on hybrid Angular/AngularJS app (Without UpgradeModule) #5131
base: master
Are you sure you want to change the base?
Conversation
Remove the `NG_DEFER_BOOTSTRAP!` on browser.get() when running Angular.
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
1 similar comment
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
|
CLAs look good, thanks! |
1 similar comment
|
CLAs look good, thanks! |
When running tests between Angular and AngularJS, Protractor will set a flag when calling browser.get to defer the bootstraping of AngularJS but this flag is also set with Angular.
The window.name variable end with a ton of NG_DEFER_BOOTSTRAP! because they are not removed when navigating to an Angular page.
See issue #5125.