This repository was archived by the owner on Nov 22, 2024. It is now read-only.
feat(common): TransferHttpCache now respects url params#1005
Merged
CaerusKaru merged 3 commits intomasterfrom Jun 9, 2018
Merged
feat(common): TransferHttpCache now respects url params#1005CaerusKaru merged 3 commits intomasterfrom
CaerusKaru merged 3 commits intomasterfrom
Conversation
Author
|
Blocked on being able to add tests |
Toxicable
commented
Jun 2, 2018
| this.transferState.remove(makeStateKey<TransferHttpResponse>('G.' + url)); | ||
| this.transferState.remove(makeStateKey<TransferHttpResponse>('H.' + url)); | ||
| // TODO: Should there be an api to search for keys? or to grab all of them | ||
| Object.keys(this.transferState['store']) |
Author
There was a problem hiding this comment.
This is a bit dodgy, should there be a proper api to do this?
Toxicable
force-pushed
the
fabian/cache-params
branch
from
19228ea to
281a45c
Compare
CaerusKaru
approved these changes
Jun 9, 2018
Member
CaerusKaru
left a comment
CaerusKaru
left a comment
There was a problem hiding this comment.
One minor nit, otherwise LGTM
| const interceptor = new TransferHttpCacheInterceptor(mockAppRef(), mockTransferState()); | ||
| const key1 = interceptor['makeCacheKey']('GET', 'https://google.com/api', | ||
| new HttpParams().append('a', 'bar').append('b', 'foo')); | ||
| const key2 = interceptor['makeCacheKey']('GET', 'https://google.com/api', |
CaerusKaru
added
PR state: LGTM
state: blocked
target: minor
Toxicable
force-pushed
the
fabian/cache-params
branch
from
bfaed5e to
041d0fc
Compare
Toxicable
force-pushed
the
fabian/cache-params
branch
from
041d0fc to
921ebd4
Compare
|
Any idea when this feature will be released? |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on the work in #987
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
TransferHttpCache does not respect url params
Issue Number: #927
What is the new behavior?
Now respects params
Does this PR introduce a breaking change?
Other information
Technically this is a breaking change since
before:
/my/url?key=value
/my/url
Both of these would override each others values in the cache
But now they'd have their own cache