feat(express-engine): add schematics#1051
Conversation
CaerusKaru
added
state: WIP
area: express-engine
target: minor
CaerusKaru
left a comment
CaerusKaru
left a comment
There was a problem hiding this comment.
Also TODO: add Bazel build steps and work out the linting errors that are bound to come up
| ### Install | ||
| Adds Angular Universal Express Engine and its depedencies and pre-configures the application. | ||
|
|
||
| - Adds Express-Engine, NgModule-Factory-Loader, ts-loader, and webpack to `package.json` |
There was a problem hiding this comment.
Will finalize docs when behavior is finalized. Part of this was stolen from Material
| @@ -0,0 +1,179 @@ | |||
| /** | |||
There was a problem hiding this comment.
More tests will be needed as behavior is finalized. These are the default tests, plus some added dependency checks. Will also need test runners that work with Bazel (Material has this already)
CaerusKaru
force-pushed
the
adam/schematics
branch
from
ce98f97 to
362c6ed
Compare
CaerusKaru
changed the title
| @@ -0,0 +1,41 @@ | |||
| /** | |||
There was a problem hiding this comment.
This file can be removed. When it was taken from Material, they use it for their update task to run things sequentially. We don't, so we don't need it here.
| const pkg = JSON.parse(buffer.toString()); | ||
|
|
||
| pkg.dependencies['@nguniversal/express-engine'] = '0.0.0-PLACEHOLDER'; | ||
| pkg.dependencies['@nguniversal/module-map-ngfactory-loader'] = '6.0.0' || '0.0.0-PLACEHOLDER'; |
There was a problem hiding this comment.
Why is the "||" needed? Isn't it a no-op?
There was a problem hiding this comment.
This is a no-op, but it enables local testing using npm link. When built though, the linked version has a long version name that coincides with the commit SHA, but the NPM version for the other @nguniversal packages remain normal.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
4 participants
for easier installation. This is basically an
enhanced version of the vanilla Universal schematic
that is available by default, where this one adds
the Express Engine, a sample Express server, as well
as some other necessary dependencies
entire Bazel setup
Fixes #968