Skip to content
This repository was archived by the owner on Nov 22, 2024. It is now read-only.

fix(schematics): ng add removes options from browser builder#1190

Merged
vikerman merged 2 commits intoangular:masterfrom
alan-agius4:ng-add-fixes
Jul 4, 2019
Merged

fix(schematics): ng add removes options from browser builder#1190
vikerman merged 2 commits intoangular:masterfrom
alan-agius4:ng-add-fixes

Conversation

@alan-agius4
Copy link
Copy Markdown
Collaborator

@alan-agius4 alan-agius4 commented Jul 4, 2019

This fixes a couple of regressions in the latest version. Were running ng add would cause configuration from the browser builder to be deleted instead of updated

Fixes #1189

Alan Agius added 2 commits July 4, 2019 08:45
This fixes a couple of regressions in the latest version. Were running `ng add` would cause configuration from the browser builder to be deleted instead of updated

Fixes #1189
This fixes a couple of regressions in the latest version. Were running `ng add` would cause configuration from the browser builder to be deleted instead of updated

Fixes #1189
Copy link
Copy Markdown
Member

@CaerusKaru CaerusKaru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@CaerusKaru CaerusKaru changed the title ng add removes options from browser builder fix(schematics): ng add removes options from browser builder Jul 4, 2019
@vikerman vikerman merged commit 10d68fc into angular:master Jul 4, 2019
@alan-agius4 alan-agius4 deleted the ng-add-fixes branch July 4, 2019 16:24
@angular-automatic-lock-bot
Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ng add breaks angular workspace config

4 participants