Skip to content
This repository was archived by the owner on Nov 22, 2024. It is now read-only.

Conversation

@alan-agius4
Copy link
Collaborator

@alan-agius4 alan-agius4 commented Dec 23, 2019

With this change we introduce a couple of changes

  • Do yarn install and code checkout once in the setup phase
  • Save cache in build-packages-dist to ensure that we cache Bazel action outputs at the very end of our builds so that we will later get better cache hit rate
  • We use circle ci 2.1 features such as action executors and commands
  • Removed the bazel-lint task which was redundant
  • We save yarn cache to circli ci cache instead of node_modules directory
  • Use a cache key fallback, so to use the last cached version when a dependency is updated.

@alan-agius4 alan-agius4 changed the title build: update @bazel/bazel to version 2.0.0 ci: test Dec 23, 2019
@alan-agius4 alan-agius4 changed the title ci: test ci: improve circle ci setup Dec 23, 2019
@alan-agius4 alan-agius4 added area: build & ci area: ci target: minor target: minor This PR is targeted for the next minor release and removed area: build & ci labels Dec 23, 2019
@alan-agius4
Copy link
Collaborator Author

@vikerman can you please remove bazel-lint from being a required task in github?

@alan-agius4 alan-agius4 marked this pull request as ready for review December 23, 2019 17:50
With this change we introduce a couple of changes

- Do `yarn install` and code checkout once in the setup phase
- Save cache in `build-packages-dist` to ensure that we cache Bazel action outputs at the very end of our builds so that we will later get better cache hit rate
- We use circle ci 2.1 features such as action executors and commands
- Removed the `bazel-lint` task which was redundant
- We save yarn cache to circli ci cache instead of node_modules directory
- Use a cache key fallback, so to use the last cached version when a dependency is updated.
@vikerman vikerman merged commit 06398b5 into angular:master Dec 30, 2019
@alan-agius4 alan-agius4 deleted the ci-circli-executors branch December 30, 2019 18:50
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jan 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area: ci target: minor target: minor This PR is targeted for the next minor release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants