Skip to content
This repository was archived by the owner on Nov 22, 2024. It is now read-only.

Conversation

@alan-agius4
Copy link
Collaborator

This commit add support to handle responses of types arraybuffer and blob in TransferHttpCacheModule.

Closes #2734

…n TransferHttpCacheModule

This commit add support to handle responses  of types `arraybuffer` and `blob` in `TransferHttpCacheModule`.

Closes angular#2734
@alan-agius4 alan-agius4 added the target: rc This PR is targeted for the next release-candidate label Aug 11, 2022
@alan-agius4 alan-agius4 requested a review from CaerusKaru August 11, 2022 11:33
Copy link
Member

@CaerusKaru CaerusKaru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the fact that the transfer cache code can probably be centralized, LGTM

@alan-agius4 alan-agius4 added action: merge PR author is ready for this to merge target: minor target: minor This PR is targeted for the next minor release and removed target: rc This PR is targeted for the next release-candidate labels Aug 11, 2022
@alan-agius4 alan-agius4 merged commit 868db00 into angular:main Aug 11, 2022
@alan-agius4 alan-agius4 deleted the transfer-state-bloc branch August 11, 2022 15:38
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge PR author is ready for this to merge target: minor target: minor This PR is targeted for the next minor release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

When using TransferHttpCacheModule, client-side arraybuffer or blob type http requests cannot be returned correctly

2 participants