This repository was archived by the owner on Nov 22, 2024. It is now read-only.
fix(@nguniversal/common): correctly handle multiple lazy CSS files #3135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alan-agius4
added
area: common
target: patch
This commit fixes an issue with the regexp that caused incorrect output. Closes angular#3128
albanx
approved these changes
May 16, 2023
| ? // Workaround for https://github.com/GoogleChromeLabs/critters/issues/64 | ||
| doc.replace( | ||
| / media="print" onload="this\.media='.+'"(?: ngCspMedia=".+")?><noscript><link .+?><\/noscript>/g, | ||
| / media="print" onload="this\.media='.+?'"(?: ngCspMedia=".+")?><noscript><link .+?><\/noscript>/g, |
There was a problem hiding this comment.
Is there any unit test to verify this line of code?
Collaborator
Author
There was a problem hiding this comment.
There is an e2e test that verifies this.
CaerusKaru
approved these changes
May 16, 2023
alan-agius4
added
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes an issue with the regexp that caused incorrect output.
Closes #3128