feat(engines): add optional url and document to render options#810
feat(engines): add optional url and document to render options#810
Conversation
|
Same error we're getting here #808 (comment) Maybe update docs to show you can optionally use those those now? |
|
Yes - Can you update the other engines with similar options and update the README? |
vikerman
left a comment
There was a problem hiding this comment.
Update README and add similar options to other engines.
|
@gdi2290 Are you still tending to this PR? If not, I can add the changes and push to this branch. |
|
@CaerusKaru you can take this PR over |
2a73669 to
c802e97
Compare
|
@vikerman This is ready for review again. @MarkPieszak can you take a look as well? |
Addressed all necessary changes
* Add url and document as optional parameters for rendering * Add optional parameters setup to the README
c802e97 to
516fbd6
Compare
|
LGTM, i'll test it out in the webpack & CLI dotnet apps when it lands as well to double check. |
|
Very nice! We are dependent on this feature in our current project. Does anyone know when this will be available on npm? |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Uh oh!
There was an error while loading. Please reload this page.