Skip to content
This repository was archived by the owner on Nov 22, 2024. It is now read-only.

feat(engines): add optional url and document to render options#810

Merged
Toxicable merged 1 commit intomasterfrom
document-url-option
Feb 26, 2018
Merged

feat(engines): add optional url and document to render options#810
Toxicable merged 1 commit intomasterfrom
document-url-option

Conversation

@PatrickJS
Copy link
Copy Markdown
Contributor

@PatrickJS PatrickJS commented Sep 29, 2017

  • Add url and document as optional parameters for rendering
  • Add optional parameters setup to the README

Tipe CMS

@Toxicable
Copy link
Copy Markdown

Toxicable commented Sep 29, 2017

Same error we're getting here #808 (comment)

Maybe update docs to show you can optionally use those those now?
Also might ben nice to update Hapi to have the same API to try be consistant

@vikerman
Copy link
Copy Markdown
Contributor

Yes - Can you update the other engines with similar options and update the README?

Copy link
Copy Markdown
Contributor

@vikerman vikerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update README and add similar options to other engines.

@CaerusKaru
Copy link
Copy Markdown
Member

@gdi2290 Are you still tending to this PR? If not, I can add the changes and push to this branch.

@PatrickJS
Copy link
Copy Markdown
Contributor Author

@CaerusKaru you can take this PR over

@CaerusKaru CaerusKaru changed the title feat(exoress-engine): optional url and document feat(engines): add optional url and document to render options Feb 20, 2018
@CaerusKaru
Copy link
Copy Markdown
Member

@vikerman This is ready for review again. @MarkPieszak can you take a look as well?

@CaerusKaru CaerusKaru dismissed vikerman’s stale review February 25, 2018 21:22

Addressed all necessary changes

* Add url and document as optional parameters for rendering
* Add optional parameters setup to the README
@CaerusKaru CaerusKaru removed their request for review February 25, 2018 21:31
Copy link
Copy Markdown
Contributor

@MarkPieszak MarkPieszak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MarkPieszak
Copy link
Copy Markdown
Contributor

LGTM, i'll test it out in the webpack & CLI dotnet apps when it lands as well to double check.

@Toxicable Toxicable merged commit 90b445b into master Feb 26, 2018
@Toxicable Toxicable deleted the document-url-option branch February 26, 2018 18:15
@sjogren
Copy link
Copy Markdown

sjogren commented Feb 27, 2018

Very nice! We are dependent on this feature in our current project. Does anyone know when this will be available on npm?

@angular-automatic-lock-bot
Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants