Skip to content
This repository was archived by the owner on Nov 22, 2024. It is now read-only.

fix(express-engine): node 9 strict engine error#853

Merged
vikerman merged 1 commit intomasterfrom
node9-strict-engine-patch
Feb 17, 2018
Merged

fix(express-engine): node 9 strict engine error#853
vikerman merged 1 commit intomasterfrom
node9-strict-engine-patch

Conversation

@MarkPieszak
Copy link
Copy Markdown
Contributor

closes #851

@Toxicable
Copy link
Copy Markdown

could you add 9 to the .travis.yml
https://github.com/angular/universal/blob/master/.travis.yml#L2

@davidloiret
Copy link
Copy Markdown

Any update? @MarkPieszak could you please sign the CLA?

@vytautas-pranskunas-
Copy link
Copy Markdown

Any progress on this?

@Toxicable
Copy link
Copy Markdown

Toxicable commented Feb 13, 2018

@MarkPieszak Looks like you have some CLA issue
needa rebase onto master
and add it to travis

@vikerman vikerman added cla: yes and removed cla: no labels Feb 13, 2018
@vikerman vikerman merged commit e4a9775 into master Feb 17, 2018
@CaerusKaru CaerusKaru deleted the node9-strict-engine-patch branch February 17, 2018 20:57
@angular-automatic-lock-bot
Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

node v9.2.0?

6 participants