You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Nov 22, 2024. It is now read-only.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Fix the ability to use TransferState and ServerTransferStateModule
What is the current behavior? (You can also link to an open issue here)
When using ServerTransferStateModule it was breaking html from being rendered on the server.
What is the new behavior (if this is a feature change)? ServerTransferStateModule now work out of the box, and also returning the moduleRef which consumers can use to do some other logic with their services before transferring it to .net.
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No breaking changes have been done, unless for some reason the consumer was using directly UniversalData.title (which is not even exposed)
@MarkPieszak I needed that to return the moduleRef to get the injector from it, ideally its just temp and it will be done in angular/platform-server i had opened an issue angular/angular#22049
Unfortunately, I had never contributed to it, its quite complex, and I use windows some tooling doesn't seems to work well.
If anyone can help on that issue, it would be awesome!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Fix the ability to use
TransferStateandServerTransferStateModuleWhat is the current behavior? (You can also link to an open issue here)
When using
ServerTransferStateModuleit was breaking html from being rendered on the server.What is the new behavior (if this is a feature change)?
ServerTransferStateModulenow work out of the box, and also returning themoduleRefwhich consumers can use to do some other logic with their services before transferring it to .net.Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No breaking changes have been done, unless for some reason the consumer was using directly
UniversalData.title(which is not even exposed)Other information: