This repository was archived by the owner on Nov 22, 2024. It is now read-only.
feat(build): add unit testing with karma#891
Merged
Toxicable merged 1 commit intoangular:masterfrom Feb 20, 2018
Merged
Conversation
Member
|
Karma runs in the browser, is that what we want here? Aren’t we testing if these modules work on the server? |
CaerusKaru
approved these changes
Feb 15, 2018
Member
CaerusKaru
left a comment
CaerusKaru
left a comment
There was a problem hiding this comment.
Discussed offline, we'll use Karma and Jasmine in tandem, and this sets up scaffolding for the former. LGTM
Author
|
Since they're very much related we should add both of them in the same PR to avoid conflicts, such as what spec files are being handled by what test runner. So I'll leave this up as reference for now while we organize the Jasmine one. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds karma test runner