Skip to content

refactor: disambiguate project testing with serve testing #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 21, 2025
Merged

refactor: disambiguate project testing with serve testing #126

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion runner/orchestration/build-serve-test-loop.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,7 @@ export async function attemptBuildAndTest(
testRepairAttempts++;
progress.log(
rootPromptDef,
'test',
'project-test',
`Trying to repair test failures (attempt #${attemptId})...`,
);

Expand Down
2 changes: 1 addition & 1 deletion runner/orchestration/serve-testing-worker.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ export async function serveAndTestApp(
progress: ProgressLogger,
userJourneyAgentTaskInput?: BrowserAgentTaskInput,
): Promise<ServeTestingResult> {
progress.log(rootPromptDef, 'serve-testing', `Testing the app`);
progress.log(rootPromptDef, 'serve-testing', `Validating the running app`);

const result = await env.executor.serveWebApplication(
evalID,
Expand Down
2 changes: 1 addition & 1 deletion runner/orchestration/test-worker.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ export async function runTest(
workerConcurrencyQueue: PQueue,
progress: ProgressLogger,
): Promise<TestExecutionResult | null> {
progress.log(rootPromptDef, 'test', `Running tests`);
progress.log(rootPromptDef, 'project-test', `Running project tests`);

try {
const result = await env.executor.executeProjectTests(
Expand Down
2 changes: 1 addition & 1 deletion runner/progress/dynamic-progress-logger.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@ export class DynamicProgressLogger implements ProgressLogger {
switch (type) {
case 'success':
case 'serve-testing':
case 'test':
case 'project-test':
case 'build':
return chalk.green;
case 'error':
Expand Down
4 changes: 2 additions & 2 deletions runner/progress/progress-logger.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import {AssessmentResult, RootPromptDefinition} from '../shared-interfaces.js';
export type ProgressType =
| 'codegen'
| 'build'
| 'test'
| 'project-test'
| 'serve-testing'
| 'success'
| 'error'
Expand All @@ -19,7 +19,7 @@ export function progressTypeToIcon(type: ProgressType): string {
return '🤖';
case 'build':
return '🔨';
case 'test':
case 'project-test':
return '🧪';
case 'serve-testing':
return '🌊';
Expand Down
Loading