feat: add timings info to eval assessment results#277
Merged
AndrewKushnir merged 1 commit intoangular:mainfrom Mar 26, 2026
Merged
feat: add timings info to eval assessment results#277AndrewKushnir merged 1 commit intoangular:mainfrom
AndrewKushnir merged 1 commit intoangular:mainfrom
Conversation
mturco
requested review from
AndrewKushnir,
crisbeto and
devversion
as code owners
crisbeto
reviewed
Mar 25, 2026
| <span>Timings</span> | ||
| </h3> | ||
| <div class="summary-card-item"> | ||
| <ul class="status-badge-group" style="display: flex; flex-direction: column; align-items: flex-start; gap: 8px; margin: 0; padding-left: 0;"> |
Member
There was a problem hiding this comment.
Should we move these styles out into the component's style file?
Collaborator
Author
There was a problem hiding this comment.
whoops, yes, meant to move those 👍
Collaborator
|
nit: for the report summary page, I think it would look great as a section similar to the "Usage Details" one (i.e. below graphs, not next to the last one). |
Collaborator
Author
now that I look at my own screenshot, I definitely agree. done! |
AndrewKushnir
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds some timing information to the report viewer's summary card and app details section.