selectedTime is not reset in MaterialTimePickerComponent when new time is set

[grundid]

When the component is reused the selectedTime variable is not cleared and the user is not able to select the same time again. You have to deselect and select the time again.

[nshahan]

cc @cpelling Any thoughts about this?

[yuandong]

Hi Adrian,
Could you explain more about steps to reproduce this bug?

Right now whenever user set new time directly in the input box, the selectedTime is reset (in onTextChange function).

[grundid]

Sure. The problem is that selectedTime is not reset when the time is set programmatically.

The steps to reproduce are:

• user selects a time in the select list
• some other event makes the business logic change the time to a new value
• now user wants to select the same time as before.

This is now not possible because the select list still shows the old time and no change event is generated when the user tries to select the new time.

[yuandong]

Aha, get it. It's fixed now. Will be included in the next release.

[grundid]

I noticed a regression with this fix and would like to suggest a different solution. With the current solution selectedTime.clear() the selected time is reset correctly but the position in the drop down is lost. Also the programmatically selected value is not selected in the drop down list at all.

Please change selectedTime.clear() to selectedTime.select(value)
If the value does not exists in the select list it won't be selected, so the value is reset.

[yuandong]

Nice catch! Updated the code as suggested, thank you Adrian.

[grundid]

I just noticed that the select method does not allow null values. So you would have to check for null and call clear() and if not null select(value)

[yuandong]

Right, already added it to the fix, test case covered it.

…

On Tue, Jan 8, 2019 at 8:30 AM Adrian Stabiszewski ***@***.***> wrote: I just noticed that the select method does not allow null values. So you would have to check for null and call clear() and if not null select(value) — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#274 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAcFxmQyAehEywJSKoZv2IzXsKuWzsKcks5vBJ1egaJpZM4UpYfl> .