Karma conf dynamic #16
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
bguiz
commented
Feb 11, 2015
bguiz
commented
- write a dynamically generated karma.conf.js
- karma wrapper modified to use karma config file
… and all bower JS files. - TODO refactor karma wrapper to read conf file from test directory instead
lib/test/karma.js
Outdated
Member
There was a problem hiding this comment.
This should not be needed with an appropriate stream filter
… minor corrections
lib/test/karma.js
Outdated
Member
There was a problem hiding this comment.
I believe that it is misleading to change the mapping like this, at least when there is no good reason to not name the internal function the same as the export.
Check with @impaler.
…uded; and use corect yargs check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.