Jshint fixes #31

impaler · 2015-03-19T04:53:19Z

@bholloway @bguiz the remaining jshint errors or any changes I made may need discussion around the existing rules.

You can run the jshint from cli with npm run lint or they will also run with the specs in npm test.

…icts with gulp task definitions.

bguiz · 2015-03-19T05:09:22Z

lib/build/browserify.js

'join_vars': false

possible?

bguiz · 2015-03-19T05:17:57Z

tasks/watch.js

Looking at the rest of this file, if there are no references to config, we can drop this statement. It was probably made redundant as part of the refactor making things more DRY.

bguiz · 2015-03-19T06:02:20Z

Looks like the freshly merged in integrations tests, almost all the tests are failing due to this error:

TypeError: Object #<Object> has no method 'addMatchers'

- also added a new npm run task for `testonly` that doesn't run lint, and isn't verbose

bguiz · 2015-03-19T06:11:51Z

I reproduced the above error on Travis locally with jasmine-node@1.x.xand upgrade to jasmine-node@2.x.x did the trick. Let's figure out why devDependecnies aren't updating on Travis

…for jasmine

bguiz · 2015-03-19T06:50:00Z

Tailing the Travis logs now, looks like the tests are finally running properly (after some trial and error getting it to work)

bguiz · 2015-03-19T10:21:22Z

Great success! ... and relatively fast too, at 6 minutes:
https://travis-ci.org/angularity/node-angularity/builds/54983907

W: http://bguiz.com

On 19 March 2015 at 15:53, Chris notifications@github.com wrote:

@bholloway https://github.com/bholloway @bguiz
https://github.com/bguiz the remaining jshint errors or any changes I
made may need discussion around the existing rules.

You can run the jshint from cli with npm run lint or they will also run

with the specs in npm test.

You can view, comment on, or merge this pull request online at:

#31
Commit Summary

Add linting to the npm test script.

jshint fixes cli.js.

jshint fixes build.js.

jshint fixes css.js.

jshint fixes html.js.

jshint fixes init.js.

jshint fixes javascript.js.

jshint fixes release.js.

jshint fixes server.js.

jshint fixes test.js.

jshint fixes watch.js.

jshint fixe webstorm.js.

Adjust jshint configuration to allow javascript url syntax that
conflicts with gulp task definitions.

jshint fixes for specs.

jshint fixes for browserify.js.

jshint fixes for node-sass.js.

jshint fixes for defaults.js.

jshint fixes for platform.js.

jshint fixes for streams.js.

jshint fixes for adjacent-files.js.

jshint fixes for brower-files.js.

jshint fixes for karma.js.

jshint fixes for hr.js.

jshint fixes for jshint-reporter.js.

jshint fixes for task-yargs-run.js.

jshint fixes for task-yargs.js.

jshint fixes for yargs.js.

Remove interactive menus, they maybe reimplemented in a future
version.

File Changes

M .jshintrc
https://github.com/angularity/node-angularity/pull/31/files#diff-0
(1)

M bin/cli.js
https://github.com/angularity/node-angularity/pull/31/files#diff-1
(8)

M lib/build/browserify.js
https://github.com/angularity/node-angularity/pull/31/files#diff-2
(6)

M lib/build/node-sass.js
https://github.com/angularity/node-angularity/pull/31/files#diff-3
(4)

D lib/cli/MenuPrompt.js
https://github.com/angularity/node-angularity/pull/31/files#diff-4
(51)

D lib/cli/generatorMenu.js
https://github.com/angularity/node-angularity/pull/31/files#diff-5
(144)

D lib/cli/initialiseMenu.js
https://github.com/angularity/node-angularity/pull/31/files#diff-6
(63)

D lib/cli/installMenu.js
https://github.com/angularity/node-angularity/pull/31/files#diff-7
(103)

D lib/cli/mainMenu.js
https://github.com/angularity/node-angularity/pull/31/files#diff-8
(86)

M lib/config/defaults.js
https://github.com/angularity/node-angularity/pull/31/files#diff-9
(2)

M lib/config/platform.js
https://github.com/angularity/node-angularity/pull/31/files#diff-10
(2)

M lib/config/streams.js
https://github.com/angularity/node-angularity/pull/31/files#diff-11
(2)

M lib/inject/adjacent-files.js
https://github.com/angularity/node-angularity/pull/31/files#diff-12
(2)

M lib/inject/bower-files.js
https://github.com/angularity/node-angularity/pull/31/files#diff-13
(6)

M lib/test/karma.js
https://github.com/angularity/node-angularity/pull/31/files#diff-14
(6)

M lib/util/hr.js
https://github.com/angularity/node-angularity/pull/31/files#diff-15
(2)

M lib/util/jshint-reporter.js
https://github.com/angularity/node-angularity/pull/31/files#diff-16
(2)

M lib/util/task-yargs-run.js
https://github.com/angularity/node-angularity/pull/31/files#diff-17
(4)

M lib/util/task-yargs.js
https://github.com/angularity/node-angularity/pull/31/files#diff-18
(4)

M lib/util/yargs.js
https://github.com/angularity/node-angularity/pull/31/files#diff-19
(10)

M package.json
https://github.com/angularity/node-angularity/pull/31/files#diff-20
(8)

M tasks/build.js
https://github.com/angularity/node-angularity/pull/31/files#diff-21
(13)

M tasks/css.js
https://github.com/angularity/node-angularity/pull/31/files#diff-22
(12)

M tasks/html.js
https://github.com/angularity/node-angularity/pull/31/files#diff-23
(14)

M tasks/init.js
https://github.com/angularity/node-angularity/pull/31/files#diff-24
(11)

M tasks/javascript.js
https://github.com/angularity/node-angularity/pull/31/files#diff-25
(17)

M tasks/release.js
https://github.com/angularity/node-angularity/pull/31/files#diff-26
(18)

M tasks/server.js
https://github.com/angularity/node-angularity/pull/31/files#diff-27
(7)

M tasks/test.js
https://github.com/angularity/node-angularity/pull/31/files#diff-28
(22)

M tasks/watch.js
https://github.com/angularity/node-angularity/pull/31/files#diff-29
(17)

M tasks/webstorm.js
https://github.com/angularity/node-angularity/pull/31/files#diff-30
(4)

A test/jshint.js
https://github.com/angularity/node-angularity/pull/31/files#diff-31
(18)

M test/specs/tasks/css-task.js
https://github.com/angularity/node-angularity/pull/31/files#diff-32
(3)

M test/specs/tasks/init.spec.js
https://github.com/angularity/node-angularity/pull/31/files#diff-33
(3)

M test/specs/tasks/javascript-task.js
https://github.com/angularity/node-angularity/pull/31/files#diff-34
(6)

M test/specs/tasks/release.spec.js
https://github.com/angularity/node-angularity/pull/31/files#diff-35
(6)

Patch Links:

https://github.com/angularity/node-angularity/pull/31.patch

https://github.com/angularity/node-angularity/pull/31.diff

—
Reply to this email directly or view it on GitHub
#31.

impaler · 2015-03-19T21:52:02Z

@bguiz cheers for the fixes, its crappy how much slower appveyor is with windoze!

bholloway · 2015-03-19T22:56:55Z

lib/build/browserify.js

This is not as intended. We want the final method above to be the fall-through. As it stands, it will be added always.

Jshint fixes + Fixed CI problems

impaler added 28 commits March 19, 2015 14:46

Add linting to the npm test script.

bf60c5b

jshint fixes cli.js.

d306d06

jshint fixes build.js.

643164a

jshint fixes css.js.

fe25ca8

jshint fixes html.js.

cc1ac80

jshint fixes init.js.

bb05a6d

jshint fixes javascript.js.

a88d577

jshint fixes release.js.

6919622

jshint fixes server.js.

a620ee8

jshint fixes test.js.

81767c7

jshint fixes watch.js.

e72a4eb

jshint fixe webstorm.js.

e234c83

Adjust jshint configuration to allow javascript url syntax that confl…

9a62230

…icts with gulp task definitions.

jshint fixes for specs.

86f46b3

jshint fixes for browserify.js.

41c66f0

jshint fixes for node-sass.js.

80d3093

jshint fixes for defaults.js.

22b6b4b

jshint fixes for platform.js.

726701b

jshint fixes for streams.js.

7d8bd06

jshint fixes for adjacent-files.js.

1cae44a

jshint fixes for brower-files.js.

caf812f

jshint fixes for karma.js.

7826432

jshint fixes for hr.js.

e0c0c3f

jshint fixes for jshint-reporter.js.

23275a1

jshint fixes for task-yargs-run.js.

18bd5da

jshint fixes for task-yargs.js.

31be93e

jshint fixes for yargs.js.

baadcec

Remove interactive menus, they maybe reimplemented in a future version.

4300cc1

bguiz reviewed Mar 19, 2015
View reviewed changes

lib/build/browserify.js

Copy link

Contributor

bguiz Mar 19, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'join_vars': false

possible?

bguiz reviewed Mar 19, 2015
View reviewed changes

=BG= fixing/ ignoring misc jshint violations

79847c6

=BG= clean up extraneous yargs instance usages in individual tasks

177bbb7

- also added a new npm run task for `testonly` that doesn't run lint, and isn't verbose

bguiz added 4 commits March 19, 2015 17:28

=BG= experimental commit to test if local jasmine installation works …

63c451d

…for jasmine

=BG= update test directory fro jasmine-node

2802f26

=BG= try npm run test instead

fe25d1e

=BG= reinstate global install

e38025e

benholloway added 2 commits March 19, 2015 18:06

removed dependency on global gulp

5485ce9

Merge remote-tracking branch 'origin/jshint' into jshint

a66d309

fail the build on lint error.

ddaac53

benholloway and others added 4 commits March 20, 2015 09:04

fixed jshint warnings, most were valid only a couple are spurious

5f6e194

Merge remote-tracking branch 'origin/jshint' into jshint

95c6c0b

run the linting test after the integration tests.

6b5ff57

Merge remote-tracking branch 'origin/jshint' into jshint

ac39ece

bholloway reviewed Mar 19, 2015
View reviewed changes

benholloway added 2 commits March 20, 2015 11:37

improvements suggested by @bguiz

50d8903

Merge remote-tracking branch 'origin/jshint' into jshint

e8725f6

bholloway added a commit that referenced this pull request Mar 20, 2015

Merge pull request #31 from angularity/jshint

a69f0a0

Jshint fixes + Fixed CI problems

bholloway merged commit a69f0a0 into master Mar 20, 2015

bholloway deleted the jshint branch March 24, 2015 06:53

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Jshint fixes #31

Jshint fixes #31

Uh oh!

impaler commented Mar 19, 2015

Uh oh!

bguiz Mar 19, 2015

Uh oh!

bguiz Mar 19, 2015

Uh oh!

bguiz commented Mar 19, 2015

Uh oh!

bguiz commented Mar 19, 2015

Uh oh!

bguiz commented Mar 19, 2015

Uh oh!

bguiz commented Mar 19, 2015

with the specs in npm test.

Uh oh!

impaler commented Mar 19, 2015

Uh oh!

bholloway Mar 19, 2015

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Jshint fixes #31

Jshint fixes #31

Uh oh!

Conversation

impaler commented Mar 19, 2015

Uh oh!

bguiz Mar 19, 2015

Choose a reason for hiding this comment

Uh oh!

bguiz Mar 19, 2015

Choose a reason for hiding this comment

Uh oh!

bguiz commented Mar 19, 2015

Uh oh!

bguiz commented Mar 19, 2015

Uh oh!

bguiz commented Mar 19, 2015

Uh oh!

bguiz commented Mar 19, 2015

with the specs in npm test.

Uh oh!

impaler commented Mar 19, 2015

Uh oh!

bholloway Mar 19, 2015

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants