Skip to content

Conversation

@bguiz
Copy link
Contributor

@bguiz bguiz commented Jan 23, 2015

NOTE that version now will require a - suffix

NOTE that version now will require a `-` suffix
@bholloway
Copy link
Member

Nice work.

  • Is it possible to make the v item into version with an alias to v. Primarily to make code more readable.

At bin/cli.js:41.

if (argv.v) {

becomes

if (argv.version) {
  • Is it appropriate to keep subCmd as taskName since every command is essentially a task. The issue being that subCmd is less descriptive while (at least in a Gulp environment) taskName is somewhat more descriptive.
  • There is a config option for the console width, currently it is hard coded to 80.

Brendan Graetz added 2 commits January 27, 2015 15:15
generate task created, used name from cli options
bholloway added a commit that referenced this pull request Jan 27, 2015
=BG= begin parsing command line arguments using yargs
@bholloway bholloway merged commit ab32d81 into angularity:master Jan 27, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants