logout event should not be called at init time

[ronanquillevere]

Hello,

I am building a single page app where you need to be logged in on every page. So on every one of my route I check if the AccessToken has been set, otherwise I redirect to the Oauth login page using the EndPoint service. After being logged, when I am redirected towards my app I have a route for retrieving the accessToken that set it to the AccessToken with AccessToken.setTokenFromString(token) as described on your webpage.

So I never really use the "sign-in" button. But I want to use the "logout" button.

On logout, I want to add the redirection towards the logout url. So I thought I was going to listen the the logout event and do a $location.path(myLougoutUrl);

Problem is the logout event is fired inside the initView() method. So after loggin, I am redirected towards my app that send the logout event at initialization then as I listen to that event then I am redirected towards the logout url automatically :(

I think logout event should NOT be fired inside initView()

I hope I was clear enough. Maybe this can be merged with issue about adding logout url

P.S. Thx for the lib :)

[ronanquillevere]

Of course a workaround can be to add a custom event sent from a custom template but I am very lazzy !

[jfturcot]

I am running into the same problem with my application, I would like to suggest something. How about you add a new event broadcast on the logout function? Something like this:

scope.logout = function() {
  AccessToken.destroy(scope);
  $rootScope.$broadcast('oauth:tokenDestroy'); 
  loggedOut();
};

This way, we could run a different event callback when a user manually signs out. This would work in our case where we want to redirect to the logout path of the Oauth provider. By keeping the event oauth:logout on the loggedOut function, all the event callbacks already using it would still be working.

I could send a pull request if this works for you.

[andreareginato]

This is a known bug. We need to fix it pretty soon, but we are not planning to work on it pretty soon. If you guys can send a pull request (with all tests correctly working) I'll be really happy to merge it.

[jfturcot]

I just sent you a pull request. Thanks for that library, it saved me a lot of time.

[mikecarroll]

+1 on this

[andreareginato]

Merging right now this pull request
#45