Skip to content

Conversation

@brlin-tw
Copy link

Currently meson.build asserts meson >= 0.44.0 however it seems to be
using features introducing in meson 0.46.0, thus spewing the following
warning messages:

WARNING: Project targetting '>= 0.44.0' but tried to use feature
introduced in '0.46.0': compiler.get_supported_link_arguments_method
WARNING: Project targetting '>= 0.44.0' but tried to use feature
introduced in '0.46.0': compiler.has_link_argument
WARNING: Project targetting '>= 0.44.0' but tried to use feature
introduced in '0.46.0': compiler.has_multi_link_argument
<stripped>
WARNING: Project specifies a minimum meson_version '>= 0.44.0' but uses
features which were added in newer versions:
* 0.46.0: {'compiler.get_supported_link_arguments_method',
'compiler.has_multi_link_argument', 'compiler.has_link_argument'}

This patch fixes the issue by bumping the version assertion to >=
0.46.0.

This patch is based on mere speculation and is NOT TESTED, please
review.

Signed-off-by: 林博仁(Buo-ren Lin) Buo.Ren.Lin@gmail.com

Currently meson.build asserts meson >= 0.44.0 however it seems to be
using features introducing in meson 0.46.0, thus spewing the following
warning messages:

```
WARNING: Project targetting '>= 0.44.0' but tried to use feature
introduced in '0.46.0': compiler.get_supported_link_arguments_method
WARNING: Project targetting '>= 0.44.0' but tried to use feature
introduced in '0.46.0': compiler.has_link_argument
WARNING: Project targetting '>= 0.44.0' but tried to use feature
introduced in '0.46.0': compiler.has_multi_link_argument
<stripped>
WARNING: Project specifies a minimum meson_version '>= 0.44.0' but uses
features which were added in newer versions:
* 0.46.0: {'compiler.get_supported_link_arguments_method',
'compiler.has_multi_link_argument', 'compiler.has_link_argument'}
```

This patch fixes the issue by bumping the version assertion to >=
0.46.0.

This patch is based on mere speculation and is NOT TESTED, please
review.

Signed-off-by: 林博仁(Buo-ren Lin) <Buo.Ren.Lin@gmail.com>
@ebassi
Copy link
Collaborator

ebassi commented Oct 4, 2018

Thanks for your contribution!

It's not really enough to just bump up the required version; in src/meson.build we're also doing a version check for 0.46 functionality.

It's also safe to update the minimum version to 0.47, which is one release behind the latest stable release of Meson.

I've opened #192 with the required changes.

Thanks again!

@ebassi ebassi closed this Oct 4, 2018
@brlin-tw brlin-tw deleted the fix-meson-version-assertion branch October 4, 2018 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants