Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds a subtitle delay and speed adjustment feature to the media player by introducing a custom text renderer with offset capabilities. The implementation uses an abstract OffsetRenderer class to handle timing adjustments and integrates it with ExoPlayer through a custom NextTextRenderer.
Changes:
- Introduced
OffsetRendererabstract class to provide time offset and speed adjustment capabilities for renderers - Implemented
NextTextRendererthat extendsOffsetRendererand wraps the defaultTextRendererwith custom timing logic - Modified
NextRenderersFactoryto use the customNextTextRendererinstead of the default text renderer
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 9 comments.
| File | Description |
|---|---|
| media3ext/src/main/java/io/github/anilbeesetti/nextlib/media3ext/rendrer/OffsetRenderer.kt | New abstract class providing timing offset/speed adjustment functionality with helper extension function |
| media3ext/src/main/java/io/github/anilbeesetti/nextlib/media3ext/rendrer/NextTextRenderer.kt | Custom text renderer implementation with ExoPlayer extension properties for subtitle delay and speed control |
| media3ext/src/main/java/io/github/anilbeesetti/nextlib/media3ext/ffdecoder/NextRenderersFactory.kt | Override of buildTextRenderers() to integrate the custom NextTextRenderer |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
media3ext/src/main/java/io/github/anilbeesetti/nextlib/media3ext/rendrer/OffsetRenderer.kt
Outdated
Show resolved
Hide resolved
...ext/src/main/java/io/github/anilbeesetti/nextlib/media3ext/ffdecoder/NextRenderersFactory.kt
Outdated
Show resolved
Hide resolved
media3ext/src/main/java/io/github/anilbeesetti/nextlib/media3ext/rendrer/NextTextRenderer.kt
Outdated
Show resolved
Hide resolved
media3ext/src/main/java/io/github/anilbeesetti/nextlib/media3ext/rendrer/NextTextRenderer.kt
Outdated
Show resolved
Hide resolved
media3ext/src/main/java/io/github/anilbeesetti/nextlib/media3ext/rendrer/NextTextRenderer.kt
Outdated
Show resolved
Hide resolved
media3ext/src/main/java/io/github/anilbeesetti/nextlib/media3ext/rendrer/OffsetRenderer.kt
Outdated
Show resolved
Hide resolved
media3ext/src/main/java/io/github/anilbeesetti/nextlib/media3ext/rendrer/NextTextRenderer.kt
Outdated
Show resolved
Hide resolved
...ext/src/main/java/io/github/anilbeesetti/nextlib/media3ext/ffdecoder/NextRenderersFactory.kt
Show resolved
Hide resolved
...ext/src/main/java/io/github/anilbeesetti/nextlib/media3ext/ffdecoder/NextRenderersFactory.kt
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.