Skip to content

Adds iOS shake animation#1085

Closed
anthony0030 wants to merge 1 commit intoanimate-css:masterfrom
anthony0030:iosShake
Closed

Adds iOS shake animation#1085
anthony0030 wants to merge 1 commit intoanimate-css:masterfrom
anthony0030:iosShake

Conversation

@anthony0030
Copy link
Copy Markdown
Contributor

Signed-off-by: Anthony Veaudry anthony@veaudry.pro

Signed-off-by: Anthony Veaudry <anthony@veaudry.pro>
@eltonmesquita
Copy link
Copy Markdown
Collaborator

eltonmesquita commented Jul 30, 2020

Thanks for the PR @anthony0030. Please read our contributing section:

Pull requests are the way to go here. We only have two rules for submitting a pull request: match the naming convention (camelCase, categorised [fades, bounces, etc]) and let us see a demo of submitted animations in a pen.

@anthony0030
Copy link
Copy Markdown
Contributor Author

Thanks @eltonmesquita ,

It would be great to add that a pen is required in the CONTRIBUTING.md.

Here is the pen: https://codepen.io/anthony0030/pen/ExPBexv

Thanks again for your time :)

@eltonmesquita
Copy link
Copy Markdown
Collaborator

Thanks for the pen! I appreciate the hard work. 😃

Honestly, I think this looks way too much with our current tada animation. At the moment I don't see why to merge it. About the contribution guide, you're right, it's missing in the guide. You'd like to send a PR fixing that?

@anthony0030
Copy link
Copy Markdown
Contributor Author

I can agree it is similar but more subtle, it is an animation I use in conjunction with animate.css on some of my projects.
What I do is if I have a useful code addition I make a pull request to the repo that the code is for. That way others can use the same code, I can just install the npm package without copying the code to every new repo I need to use it in and the best scenario is someone improves my code. Here is the pull request for the documentation you asked me for #1089

@daneden
Copy link
Copy Markdown
Collaborator

daneden commented Aug 12, 2020

Hey @anthony0030! I think I have to side with @eltonmesquita here; this animation seems too similar to current ones in Animate.css, including tada and shakeX. I’m going to close this PR. I appreciate the submission, but thanks for also updating the contributor guidelines in #1089!

@daneden daneden closed this Aug 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants