Fix setuptools package discovery#16
Merged
anistark merged 2 commits intoJul 4, 2025
Merged
Conversation
Owner
|
we can try |
Contributor
Author
|
Sounds good! I opened a follow-up PR at #17; linked above. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
src/layouts,setuptoolsautomatically discovers packages undersrc/<package_name>, but if you specify bothtool.setuptools.packagesandtool.setuptools.package-dir, thenpackagesmust have a list of all subpackages insidetool.setuptools.package-dir. This PR removestool.setuptools.packagesin favour oftool.setuptools.packages.findso that we can rely on automated discovery mechanisms.I also introduced a
MANIFEST.infile here as I noticed that the__pycache__files in the installation were being included.Switching to
hatchlingwould provide better defaults; please let me know if you desire it and I can open a follow-up PR.Closes #15