Merged
Conversation
malek10xdev
reviewed
Feb 24, 2026
Collaborator
malek10xdev
left a comment
There was a problem hiding this comment.
Can't find the changes where passive_mining will be passed to tasks-manager.crateTask, is it implemented or still ?
backend/src/middleware/auth.ts
Outdated
|
|
||
| if (userId) { | ||
| // Create a service user object with the extracted userId | ||
| const serviceUser: User = { |
Collaborator
There was a problem hiding this comment.
Use supabase.getUser to validate that id actually exists and also you have complete user object instead of hardcoded
malek10xdev
reviewed
Feb 24, 2026
| // Extract userId from route or query params | ||
| const userId = req.params.userId ?? req.query.userId; | ||
|
|
||
| if (userId) { |
Collaborator
There was a problem hiding this comment.
Fetch user and wait for response if userId doesn't exist return status 404 if error 500 otherwise next()
malek10xdev
approved these changes
Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.