Display "Current Interval" on the 'Set Due Date' dialog#18028
Conversation
|
Important Maintainers: This PR contains Strings changes
|
AnkiDroid/src/main/java/com/ichi2/anki/scheduling/SetDueDateDialog.kt
Outdated
Show resolved
Hide resolved
AnkiDroid/src/main/java/com/ichi2/anki/scheduling/SetDueDateViewModel.kt
Show resolved
Hide resolved
|
Hey @BrayanDSO and @ShridharGoel, thanks for the reviews! I've addressed your comments--please take a look. |
Arthur-Milchior
left a comment
There was a problem hiding this comment.
I'd appreciate if you could ensure it all fits in a single commit, and have the commit message we want in the history.
Also a small change in documentation, and all is good.
I'd appreciate some tests too. We already have unit tests for SetDueDate dialog and view model, so it should hopefully be little extra work.
AnkiDroid/src/main/java/com/ichi2/anki/scheduling/SetDueDateViewModel.kt
Outdated
Show resolved
Hide resolved
AnkiDroid/src/main/java/com/ichi2/anki/scheduling/SetDueDateViewModel.kt
Outdated
Show resolved
Hide resolved
AnkiDroid/src/main/java/com/ichi2/anki/scheduling/SetDueDateViewModel.kt
Outdated
Show resolved
Hide resolved
AnkiDroid/src/main/java/com/ichi2/anki/scheduling/SetDueDateViewModel.kt
Outdated
Show resolved
Hide resolved
david-allison
left a comment
There was a problem hiding this comment.
Just a request that this has been tested. Cheers!
AnkiDroid/src/main/java/com/ichi2/anki/scheduling/SetDueDateViewModel.kt
Outdated
Show resolved
Hide resolved
AnkiDroid/src/main/java/com/ichi2/anki/scheduling/SetDueDateViewModel.kt
Outdated
Show resolved
Hide resolved
Only for review 'type' cards: other types don't have an interval Only when 1 card is selected Fixes 16406
dd05b0a to
ebcf581
Compare
|
Strings @mikehardy - pinging as I know you're in the area |
|
Maintainers: Please Sync Translations to produce a commit with only the automated changes from this PR. Read more about updating strings on the wiki, |
|
Hi there @theMr17! This is the OpenCollective Notice for PRs merged from 2025-06-01 through 2025-06-30 If you are interested in compensation for this work, the process with details is here: https://github.com/ankidroid/Anki-Android/wiki/OpenCollective-Payment-Process#how-to-get-paid We only post one comment per person per month to avoid spamming you, regardless of the number of PRs merged, but this note applies to all PRs merged for this month Please understand that our monthly budget is never guaranteed to cover all claims - the cap on payments-per-person may be lower, but we try to make our process as fair and transparent as possible, we just need your understanding. Thanks! |
Purpose / Description
This PR enhances the 'Set Due Date' dialog by displaying the "Current Interval" when a single card is selected. This provides users with better context on the existing interval before setting a new due date. If multiple cards are selected, the interval is hidden, as displaying it would not be meaningful in that scenario.
Fixes
Approach
Adds a display of the current interval to the "Set Due Date" dialog when a single card is selected. If multiple cards are selected, the interval is hidden as it would not be meaningful.
How Has This Been Tested?
Checklist
Please, go through these checks before submitting the PR.