Skip to content

Comments

Display "Current Interval" on the 'Set Due Date' dialog#18028

Merged
david-allison merged 1 commit intoankidroid:mainfrom
theMr17:feat/current-interval-on-due-date-dialog
Jun 9, 2025
Merged

Display "Current Interval" on the 'Set Due Date' dialog#18028
david-allison merged 1 commit intoankidroid:mainfrom
theMr17:feat/current-interval-on-due-date-dialog

Conversation

@theMr17
Copy link
Contributor

@theMr17 theMr17 commented Feb 26, 2025

Purpose / Description

This PR enhances the 'Set Due Date' dialog by displaying the "Current Interval" when a single card is selected. This provides users with better context on the existing interval before setting a new due date. If multiple cards are selected, the interval is hidden, as displaying it would not be meaningful in that scenario.

Fixes

Approach

Adds a display of the current interval to the "Set Due Date" dialog when a single card is selected. If multiple cards are selected, the interval is hidden as it would not be meaningful.

How Has This Been Tested?

Single date selection (single card) Ranged date selection (single card) Single date selection (multiple cards)
image image image

Checklist

Please, go through these checks before submitting the PR.

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

@github-actions
Copy link
Contributor

Important

Maintainers: This PR contains Strings changes

  1. Sync Translations before merging this PR and wait for the action to complete
  2. Review and merge the auto-generated PR in order to sync all user-submitted translations
  3. Sync Translations again and merge the PR so the huge automated string changes caused by merging this PR are by themselves and easy to review

@BrayanDSO BrayanDSO added the Needs Author Reply Waiting for a reply from the original author label Feb 28, 2025
@theMr17
Copy link
Contributor Author

theMr17 commented Mar 8, 2025

Hey @BrayanDSO and @ShridharGoel, thanks for the reviews! I've addressed your comments--please take a look.

@ShridharGoel ShridharGoel added Needs Second Approval Has one approval, one more approval to merge and removed Needs Author Reply Waiting for a reply from the original author labels Mar 8, 2025
Copy link
Member

@Arthur-Milchior Arthur-Milchior left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd appreciate if you could ensure it all fits in a single commit, and have the commit message we want in the history.
Also a small change in documentation, and all is good.

I'd appreciate some tests too. We already have unit tests for SetDueDate dialog and view model, so it should hopefully be little extra work.

Copy link
Member

@david-allison david-allison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One issue with non review cards

This code is exceptionally clean, thank you!

@lukstbit lukstbit added the squash-merge A squash & force push is required. The PR author may do this to speed up the merge process. label Mar 12, 2025
Copy link
Member

@david-allison david-allison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a request that this has been tested. Cheers!

@mikehardy mikehardy requested a review from david-allison June 2, 2025 16:31
@mikehardy mikehardy added the Needs reviewer reply Waiting for a reply from another reviewer label Jun 2, 2025
Copy link
Member

@david-allison david-allison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cheers!

Only for review 'type' cards: other types don't have an interval

Only when 1 card is selected

Fixes 16406
@david-allison david-allison force-pushed the feat/current-interval-on-due-date-dialog branch from dd05b0a to ebcf581 Compare June 2, 2025 17:17
@david-allison david-allison enabled auto-merge June 2, 2025 17:17
@david-allison david-allison disabled auto-merge June 2, 2025 17:17
@david-allison
Copy link
Member

Strings @mikehardy - pinging as I know you're in the area

@david-allison david-allison added Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) and removed Needs Second Approval Has one approval, one more approval to merge squash-merge A squash & force push is required. The PR author may do this to speed up the merge process. Needs reviewer reply Waiting for a reply from another reviewer labels Jun 2, 2025
@david-allison david-allison enabled auto-merge June 9, 2025 14:21
@david-allison david-allison disabled auto-merge June 9, 2025 14:21
@david-allison david-allison enabled auto-merge June 9, 2025 14:21
@david-allison david-allison added this pull request to the merge queue Jun 9, 2025
Merged via the queue into ankidroid:main with commit a1e88ee Jun 9, 2025
9 checks passed
@github-actions github-actions bot added this to the 2.21 release milestone Jun 9, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jun 9, 2025

Maintainers: Please Sync Translations to produce a commit with only the automated changes from this PR.

Read more about updating strings on the wiki,

@github-actions github-actions bot removed the Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) label Jun 9, 2025
@david-allison
Copy link
Member

Hi there @theMr17! This is the OpenCollective Notice for PRs merged from 2025-06-01 through 2025-06-30

If you are interested in compensation for this work, the process with details is here: https://github.com/ankidroid/Anki-Android/wiki/OpenCollective-Payment-Process#how-to-get-paid

We only post one comment per person per month to avoid spamming you, regardless of the number of PRs merged, but this note applies to all PRs merged for this month

Please understand that our monthly budget is never guaranteed to cover all claims - the cap on payments-per-person may be lower, but we try to make our process as fair and transparent as possible, we just need your understanding.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Enhancement] Display "current interval" on the 'Set Due Date' dialog

7 participants