Duplicate Due column Fix

[dorrin-sot]

Purpose / Description

The columns sometimes were not distinct in CardBrowser.

Fixes

• Fixes Duplicate Due column #17892

Approach

I modified BrowserColumnCollection::load to return only distinct columns.

How Has This Been Tested?

I wrote a unit test to override the CardBrowser columns in SharedPreferences so it has duplicate values and checked its distinctness afterward.

Checklist

• You have a descriptive commit message with a short title (first line, max 50 chars).
• You have commented your code, particularly in hard-to-understand areas
• You have performed a self-review of your own code
• UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
• UI Changes: You have tested your change using the Google Accessibility Scanner

[Arthur-Milchior]

Pretty nice commit, thanks a lot.
My only regret is that it was not clear why it was indeed the right commit. In particular, I didn't know that it ensured that the preference would be corrected the next time the user change it as a side effect of your commit.

So, I approve the code and the test, still, I'd really want that your commit message, now and in the future, be more descriptive please. That you help reviewers understand what you did, why it works, what impact it has, without us having to look in details at the code you didn't touch

[david-allison]

Looks great, cheers!

[mikehardy]

LGTM, thank you!

[mikehardy]

squashed locally and re-pushed so I can use merge queue

[david-allison]

Hi there @dorrin-sot! This is the OpenCollective Notice for PRs merged from 2025-04-01 through 2025-04-30

If you are interested in compensation for this work, the process with details is here: https://github.com/ankidroid/Anki-Android/wiki/OpenCollective-Payment-Process#how-to-get-paid

We only post one comment per person per month to avoid spamming you, regardless of the number of PRs merged, but this note applies to all PRs merged for this month

Please understand that our monthly budget is never guaranteed to cover all claims - the cap on payments-per-person may be lower, but we try to make our process as fair and transparent as possible, we just need your understanding.

Thanks!