fix: adjust deck picker footer font automatically to fit in one line#18159
Closed
sddzhyc wants to merge 1 commit intoankidroid:mainfrom
Closed
fix: adjust deck picker footer font automatically to fit in one line#18159sddzhyc wants to merge 1 commit intoankidroid:mainfrom
sddzhyc wants to merge 1 commit intoankidroid:mainfrom
Conversation
|
First PR! 🚀 We sincerely appreciate that you have taken the time to propose a change to AnkiDroid! Please have patience with us as we are all volunteers - we will get to this as soon as possible. |
BrayanDSO
reviewed
Mar 25, 2025
Member
BrayanDSO
left a comment
There was a problem hiding this comment.
Have you tested increasing the font size in the system settings?
Author
|
Yes, the above screenshots are tested in the largest font size in the system settings. |
criticalAY
approved these changes
Mar 28, 2025
Contributor
criticalAY
left a comment
There was a problem hiding this comment.
LGTM! I tested it on two devices works fine thanks!
BrayanDSO
requested changes
Mar 29, 2025
Member
|
I'm closing the original issue as solved, so I'll close this PR as well. Sorry for the time spent here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Purpose / Description
The purpose of this change is to fix the string overflowing problem on deck picker footer, while keeping the text in a single line.
Fixes
Approach
autoSizeTextTypeattribute is added to allow adjust font automaticallymaxLines="1"is added to force the text shown in a single lineautoSizeMaxTextSize,autoSizeMinTextSizeandautoSizeStepGranularityattribute is added to control a range of minimum and maximum text sizes and a dimension that specifies the size of each stepHow Has This Been Tested?
This change has been tested using different font sizes and languages.
Screenshot
As shown in these images, with changing length and language of the text, the font size can adjust automatically to keep showing fully in a single line.
Checklist
Please, go through these checks before submitting the PR.