Skip to content

Conversation

@david-allison
Copy link
Member

@david-allison david-allison commented Jan 26, 2026

Purpose / Description

Before this change, 'add' was the wrong color

Screenshot 2026-01-26 at 10 42 04 Screenshot 2026-01-26 at 10 43 05

Fixes

Checklist

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

Copy link
Member

@BrayanDSO BrayanDSO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is ic_add, which now is the same of ic_add_white. We should use only one, or use ic_add here

@BrayanDSO BrayanDSO added Needs Author Reply Waiting for a reply from the original author and removed Needs Review labels Jan 26, 2026
@david-allison
Copy link
Member Author

david-allison commented Jan 27, 2026

Thanks! I was laser-focused on getting the screen working.

Let's combine them. This was likely from a past where ?attr/colorControlNormal didn't work (below API 21 IIRC)

@david-allison david-allison added Needs Review and removed Needs Author Reply Waiting for a reply from the original author labels Jan 27, 2026
and fix the tint of the icon in the new CardBrowser SearchBar

`ic_add_white` did not use `?attr/colorControlNormal`.

This was added in 2021, I suspect this was before it was supported.

`ic_add` was added in 2023, with `colorControlNormal`

So remove `ic_add_white`

* 4830272
* 988033a
@david-allison david-allison added the Needs Author Reply Waiting for a reply from the original author label Jan 27, 2026
@david-allison
Copy link
Member Author

I'd like to triple check testing here

@david-allison
Copy link
Member Author

I'm happy

@david-allison david-allison removed the Needs Author Reply Waiting for a reply from the original author label Jan 29, 2026
@BrayanDSO BrayanDSO added Needs Second Approval Has one approval, one more approval to merge and removed Needs Review labels Jan 29, 2026
Copy link
Member

@lukstbit lukstbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@lukstbit lukstbit added Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) and removed Needs Second Approval Has one approval, one more approval to merge labels Feb 3, 2026
@lukstbit lukstbit added this pull request to the merge queue Feb 3, 2026
Merged via the queue into ankidroid:main with commit 7a926db Feb 3, 2026
15 checks passed
@github-actions github-actions bot added this to the 2.24 release milestone Feb 3, 2026
@github-actions github-actions bot removed the Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) label Feb 3, 2026
@david-allison david-allison deleted the add-icon-tint branch February 3, 2026 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants