feat(card-browser): new UI to select sort order #20240
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
david-allison
added
the
Needs Author Reply
Contributor
|
Important Maintainers: This PR contains Strings changes
|
david-allison
force-pushed
the
sort-order-ui-model
branch
from
3b2c03d to
a8d817c
Compare
* Add `CheckResult` * make `internal` * Remove SortOrderUtil` * replace `else` with concrete type * Add tests
* Renamed original implementations: * findCards => findCardsLegacy * findNotes => findNotesLegacy * BuiltinSortKind => LegacyBuiltinSortKind * Adds: * BuiltinColumnSortKind * collection.buildSortMode * updates `FinderTest` and `SortOrderTest` All but one method was updated to the non-legacy implementation due to: * only `query` was set * a valid `SortOrder` was provided (typically `NoOrdering`) * test-only method https://github.com/ankitects/anki/blob/6247c92dcce0204f0e666b9e9e5355d2a15649d6/pylib/anki/collection.py#L634-L712
* findCardsLegacy * findNotesLegacy Only `CardBrowser.searchForRows` used the order parameter I have confirmed that the implementations are the same
The `CardId` parameter is marked as missing, removing it breaks compilation
Co-authored-by: ShaanNarendran <shaannaren06@gmail.com>
* Move 'SortType' to 'LegacySortType' * Define and test the new 'SortType' Prep for issue 17732
Prep for issue 17732
Prep for issue 17732
david-allison
force-pushed
the
sort-order-ui-model
branch
from
a8d817c to
225ff72
Compare
david-allison
force-pushed
the
sort-order-ui-model
branch
from
225ff72 to
2003547
Compare
david-allison
added
Blocked by dependency
Prep for issue 17732
And remove old implementation Fixes 17732
david-allison
force-pushed
the
sort-order-ui-model
branch
from
2003547 to
0c89f27
Compare
david-allison
commented
Jan 31, 2026
| * | ||
| * 'Question' is unavailable in Cards mode | ||
| */ | ||
| val available: Boolean |
Member
Author
There was a problem hiding this comment.
Rename to canBeSorted
Member
Author
|
Use the colors/style in bc78d4a for the buttons. Much better than my attempt |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose / Description
We define and use
SortOrderBottomSheetFragment, a bottom sheet fragment which supports:The order of columns is:
This replaces the previous implementation
Fixes
Approach
Define a standard bottom sheet fragment:
SortOrderBottomSheetFragmentwithnewInstance()to initialize args from the collectionDefine an adapter, which does most of the heavy lifting
itemViewTypefor the logic - didn't feel worthwhileHow Has This Been Tested?
Extensive unit tests
Checklist