Skip to content

fix(export): use Bundle.putLongArray#20536

Merged
criticalAY merged 1 commit intoankidroid:mainfrom
david-allison:fix-exported-ids
Mar 21, 2026
Merged

fix(export): use Bundle.putLongArray#20536
criticalAY merged 1 commit intoankidroid:mainfrom
david-allison:fix-exported-ids

Conversation

@david-allison
Copy link
Member

Purpose / Description

The previous code worked incidentally. List<Long> is not always Parcelable. This was exposed when moving away from bundleOf

Approach

Convert the list to a long array

How Has This Been Tested?

API 33 emulator

Learning (optional, can help others)

bundleOf() is deprecated, exposing this issue: https://issuetracker.google.com/issues/434825212

Checklist

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

The previous code worked incidentally.
List<Long> is not always Parcelable

bundleOf() is deprecated, exposing this issue:
https://issuetracker.google.com/issues/434825212
@david-allison david-allison added this to the 2.24 release milestone Mar 21, 2026
@david-allison david-allison added Review High Priority Request for high priority review Needs Review and removed Needs Review Review High Priority Request for high priority review labels Mar 21, 2026
Copy link
Member

@lukstbit lukstbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lukstbit lukstbit added Review High Priority Request for high priority review Needs Second Approval Has one approval, one more approval to merge and removed Needs Review labels Mar 21, 2026
Copy link
Contributor

@criticalAY criticalAY left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thankyou!

@criticalAY criticalAY added this pull request to the merge queue Mar 21, 2026
Merged via the queue into ankidroid:main with commit a5d2173 Mar 21, 2026
19 checks passed
@github-actions github-actions bot removed Review High Priority Request for high priority review Needs Second Approval Has one approval, one more approval to merge labels Mar 21, 2026
@david-allison david-allison deleted the fix-exported-ids branch March 21, 2026 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants